[SPIRV] Allow sampled type to be half for universal#7252
Merged
s-perron merged 3 commits intomicrosoft:mainfrom Mar 24, 2025
Merged
[SPIRV] Allow sampled type to be half for universal#7252s-perron merged 3 commits intomicrosoft:mainfrom
s-perron merged 3 commits intomicrosoft:mainfrom
Conversation
We have a check that the sample type for an image cannot be a 16-bit float. This is true for Vulkan, but not true for general spir-v. We modify this check to only apply when the target env is vulkan. Wew also move the check to spirvemitter where the error handling is better. In its current location, the compiler continue to run with an unexpected nullptr. Fixes microsoft#6987 Fixes microsoft#6989
cassiebeckley
approved these changes
Mar 24, 2025
Keenuts
approved these changes
Mar 24, 2025
Co-authored-by: Cassandra Beckley <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a check that the sample type for an image cannot be a 16-bit
float. This is true for Vulkan, but not true for general spir-v.
We modify this check to only apply when the target env is vulkan. Wew
also move the check to spirvemitter where the error handling is better.
In its current location, the compiler continue to run with an unexpected
nullptr.
Fixes #6987
Fixes #6989